From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29979 invoked by alias); 22 Jan 2010 22:07:13 -0000 Received: (qmail 29966 invoked by uid 22791); 22 Jan 2010 22:07:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jan 2010 22:07:05 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0MM73tM004246 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Jan 2010 17:07:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0MM72xB029626; Fri, 22 Jan 2010 17:07:03 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0MM717C007411; Fri, 22 Jan 2010 17:07:02 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9A683378267; Fri, 22 Jan 2010 15:07:01 -0700 (MST) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: Patch for cp-valprint.c References: <4B59DF28.4090306@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 22 Jan 2010 22:07:00 -0000 In-Reply-To: <4B59DF28.4090306@redhat.com> (Chris Moller's message of "Fri, 22 Jan 2010 12:23:52 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00551.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> While working on something else, I found the following: Chris> /* FIXME (alloca): unsafe if baseclass is really really large. */ Chris> gdb_byte *buf = alloca (TYPE_LENGTH (baseclass)); Chris> The attached patch replaces that with a xmalloc/xfree pair. Please send unidiff or context diffs. I just put "diff -u -N" into my ~/.cvsrc. I've never regretted it. >> buf = xmalloc (TYPE_LENGTH (baseclass)); >> if (buf) { >> xfree (buf); >> buf = NULL; In gdb you can't generally do pairings like this, due to exceptions. Instead, you must make a cleanup. Also, you don't need to check the argument to xfree; xfree handles NULL pointers fine. Chris> -FAIL: gdb.base/solib-display.exp: after rerun Chris> -FAIL: gdb.base/solib-display.exp: after rerun (GDB internal error) Chris> -PASS: gdb.base/solib-display.exp: break 25 Chris> -FAIL: gdb.base/solib-display.exp: continue (GDB internal error) Chris> -PASS: gdb.base/solib-display.exp: display main_global Chris> -PASS: gdb.base/solib-display.exp: display a_local Chris> -PASS: gdb.base/solib-display.exp: display a_static Chris> -PASS: gdb.base/solib-display.exp: break 25 Chris> -FAIL: gdb.base/solib-display.exp: continue Chris> +ERROR: Process no longer exists Chris> +UNRESOLVED: gdb.base/solib-display.exp: after rerun Chris> +WARNING: remote_expect statement without a default case?! Chris> +FAIL: gdb.base/solib-display.exp: Can't run to main (3) Jan has a patch pending for this. I don't know about the other changes offhand. Sometimes I re-run the test suite to see if problems just go away... though I think Jan has put some work into making this happen less. Tom