From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77079-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25653 invoked by alias); 15 Dec 2010 20:51:54 -0000
Received: (qmail 25646 invoked by uid 22791); 15 Dec 2010 20:51:54 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 20:51:49 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBFKpa8v011848	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 15 Dec 2010 15:51:36 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBFKpY0A022594;	Wed, 15 Dec 2010 15:51:35 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oBFKpYSo027498;	Wed, 15 Dec 2010 15:51:34 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id C1D8B379182; Wed, 15 Dec 2010 13:51:33 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: Doug Evans <dje@google.com>, pedro@codesourcery.com, eliz@gnu.org,        gdb-patches@sourceware.org
Subject: Re: [patch] Add an evaluation function hook to Python breakpoints.
References: <m38vztlr2r.fsf@redhat.com>	<AANLkTimS_32d+7phemj95qCSdJzgXXOxjMhbt_9+i8D6@mail.gmail.com>	<m34oags1q1.fsf@fleche.redhat.com> <m3r5dj6oed.fsf@redhat.com>
Date: Wed, 15 Dec 2010 20:51:00 -0000
In-Reply-To: <m3r5dj6oed.fsf@redhat.com> (Phil Muldoon's message of "Wed, 15	Dec 2010 15:34:18 +0000")
Message-ID: <m3mxo6lpyi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00324.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> +  struct cleanup *cleanup = ensure_python_env (get_current_arch (),
Phil> +					       current_language);

I didn't notice this before.  I think this should use the breakpoint's
arch and language.

Phil> +  if (PyObject_HasAttrString (py_bp, method))
Phil> +    {
Phil> +      PyObject *result = PyObject_CallMethod (py_bp, method, NULL);

Since we're now overloading the "condition" member, what happens if the
user sets a condition on the breakpoint?

I think we may need an additional check here, to see if the "condition"
member is a callable object.

Tom