From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18787 invoked by alias); 11 Mar 2011 18:27:26 -0000 Received: (qmail 18779 invoked by uid 22791); 11 Mar 2011 18:27:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 18:27:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2BIREhk011090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Mar 2011 13:27:17 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2BHikM2024321; Fri, 11 Mar 2011 12:44:46 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2BHij37006101; Fri, 11 Mar 2011 12:44:46 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id B69A53797CD; Fri, 11 Mar 2011 10:44:45 -0700 (MST) From: Tom Tromey To: pmuldoon@redhat.com Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] [python] Implement stop_p for gdb.Breakpoint References: Date: Fri, 11 Mar 2011 18:36:00 -0000 In-Reply-To: (Phil Muldoon's message of "Fri, 11 Mar 2011 11:39:12 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00669.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> Here is the latest patch. I've added the mutual exclusion to setting Phil> the CLI condition and the Python method. I renamed the method to Phil> 'stop'. Plus all the other review comments regarding the #HAVE Python Phil> defines . I included some changes from the branch that alter how Phil> breakpoints are initialized (the tests require those changes). I forgot to mention -- I think this should have a NEWS entry. Tom