From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1287 invoked by alias); 24 May 2011 18:56:45 -0000 Received: (qmail 1279 invoked by uid 22791); 24 May 2011 18:56:45 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 18:56:31 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4OIuPHU001205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 May 2011 14:56:25 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4OIuOGo028665; Tue, 24 May 2011 14:56:24 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4OIuN7P020776; Tue, 24 May 2011 14:56:24 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2616E37919A; Tue, 24 May 2011 12:56:22 -0600 (MDT) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: don't run watchpoint commands when the watchpoint goes out of scope References: <201105241607.21740.pedro@codesourcery.com> Date: Tue, 24 May 2011 18:56:00 -0000 In-Reply-To: <201105241607.21740.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 24 May 2011 16:07:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00573.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Walking the related breakpoints in map_breakpoint_numbers Pedro> is bogus. It should be the map_breakpoint_numbers' callback Pedro> responsibility to iterate over the related breakpoints if it Pedro> so needs/wants. I totally agree; but I wonder what relies on this. Annotation indicates that this code has been there forever. Tom