From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82988-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21375 invoked by alias); 12 Aug 2011 15:40:46 -0000
Received: (qmail 21367 invoked by uid 22791); 12 Aug 2011 15:40:45 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Aug 2011 15:40:25 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7CFeN18032085	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 12 Aug 2011 11:40:24 -0400
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7CFeLLi002588;	Fri, 12 Aug 2011 11:40:22 -0400
From: Phil Muldoon <pmuldoon@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] set/show extended-prompt
References: <m3liv0yol6.fsf@redhat.com>	<CACTLOFoH-uGtoZ8Vp9GNpgV8ZZVaitnseMqRj83BS_Vf02FNeg@mail.gmail.com>	<m3r54qlm3b.fsf@redhat.com>
Reply-to: pmuldoon@redhat.com
X-URL: http://www.redhat.com
Date: Fri, 12 Aug 2011 15:40:00 -0000
In-Reply-To: <m3r54qlm3b.fsf@redhat.com> (Phil Muldoon's message of "Fri, 12	Aug 2011 15:51:20 +0100")
Message-ID: <m3mxfe63kq.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00248.txt.bz2

Phil Muldoon <pmuldoon@redhat.com> writes:

> Matt Rice <ratmice@gmail.com> writes:
>
>> On Thu, Aug 11, 2011 at 8:06 AM, Phil Muldoon <pmuldoon@redhat.com> wrot=
e:
>>
>>> +@item @var{\e}
>>> +Substitute an ESC character.
>>
>>> +def _prompt_esc(attr):
>>> + =C2=A0 =C2=A0"The ESC character."
>>> + =C2=A0 =C2=A0return '\033'
>>
>> won't usage of this (without an equivalent to bash's \[ \]) mess up
>> the prompt width calculation?
>> maybe something like...
>
> Not sure what you mean by width in this context.  I checked strlen and
> for /efoo/e and it reported the length at five?

We talked a little about this on irc.  In the submitted case, readline
is counting the actual \e as a character, so when it re-displays a prompt
it calculates the prompt length incorrectly (including the ESC).  Matt's
approach nullifies this.  I'll adjust the patch, documentation and tests
accordingly

Cheers,

Phil.

>> @item @var{\[}
>> Begins a sequence of non-printing characters.
>> @item @var{\]}
>> Ends a sequence of non-printing characters.
>>
>> def _prompt_nonprinting_begin(attr):
>>    "Begins a sequence of non-printing characters."
>>    return '\001'
>>
>> def _prompt_nonprinting_end(attr):
>>    "Ends a sequence of non-printing characters."
>>    return '\002'