From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5395 invoked by alias); 29 Oct 2011 19:55:47 -0000 Received: (qmail 5387 invoked by uid 22791); 29 Oct 2011 19:55:47 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Oct 2011 19:55:32 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9TJtUA1012431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 29 Oct 2011 15:55:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9TJCkNL022384; Sat, 29 Oct 2011 15:12:46 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9TJCihs015813; Sat, 29 Oct 2011 15:12:45 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFC] [python] Fix field list of typedef regression References: <20111029081242.9FA26246191@ruffy.mtv.corp.google.com> Date: Sat, 29 Oct 2011 22:17:00 -0000 In-Reply-To: <20111029081242.9FA26246191@ruffy.mtv.corp.google.com> (Doug Evans's message of "Sat, 29 Oct 2011 01:12:42 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00807.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> Question: What's the right way to handle ref counting here? Doug> + CHECK_TYPEDEF (checked_type); Doug> + if (checked_type != type) Doug> + self = type_to_type_object (checked_type); Doug> + /* FIXME: reference counting of self? */ type_to_type_object returns a new reference. So the caller is responsible for decref'ing it. I think assigning to self is unexpected. Doug> + } Doug> + GDB_PY_HANDLE_EXCEPTION (except); I'd pull the type_to_type_object call out of the TRY_CATCH. Then you don't have to handle a decref on the exception return. Tom