From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7495 invoked by alias); 15 Dec 2013 04:04:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7473 invoked by uid 89); 15 Dec 2013 04:04:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2013 04:04:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBF44FeS022591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 14 Dec 2013 23:04:15 -0500 Received: from psique (ovpn-113-60.phx2.redhat.com [10.3.113.60]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBF44CIX027305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 14 Dec 2013 23:04:13 -0500 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix for PR breakpoints/16297: Fix catch syscall to work with syscall 0 References: <87fvpu4vgh.fsf@lestat.krisman.be> X-URL: http://www.redhat.com Date: Sun, 15 Dec 2013 04:04:00 -0000 In-Reply-To: <87fvpu4vgh.fsf@lestat.krisman.be> (Gabriel Krisman Bertazi's message of "Sun, 15 Dec 2013 01:57:50 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00558.txt.bz2 On Sunday, December 15 2013, Gabriel Krisman Bertazi wrote: > This is a fix for bug 16297. The problem occurs when the user attempts > to catch any syscall 0 (such as syscall read on Linux/x86_64). GDB was > not able to catch the syscall and was missing the breakpoint. > > Now, breakpoint_hit_catch_syscall returns immediately when it finds the > correct syscall number, avoiding a following check for the end of the > search vector, that returns a no hit if the syscall number was zero. Thanks. Just for the record, I pre-reviewed Krisman's patch and it's OK. I am also helping him in obtaining the copyright assignment. I will send a patch to test this feature as soon as my other patch (which touches catch-syscall.exp and improves it) gets approved. -- Sergio