From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125112-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 62288 invoked by alias); 10 Aug 2015 19:43:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 62279 invoked by uid 89); 10 Aug 2015 19:43:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pd0-f171.google.com
Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 10 Aug 2015 19:43:39 +0000
Received: by pdco4 with SMTP id o4so74787468pdc.3        for <gdb-patches@sourceware.org>; Mon, 10 Aug 2015 12:43:37 -0700 (PDT)
X-Received: by 10.70.23.196 with SMTP id o4mr35540695pdf.1.1439235817368;        Mon, 10 Aug 2015 12:43:37 -0700 (PDT)
Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53])        by smtp.gmail.com with ESMTPSA id qp13sm20874881pbb.9.2015.08.10.12.43.36        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Mon, 10 Aug 2015 12:43:36 -0700 (PDT)
From: Doug Evans <xdje42@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v6 8/9] Explicit locations: MI support for explicit locations
References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com>	<20150805233318.21646.71143.stgit@valrhona.uglyboxes.com>
Date: Mon, 10 Aug 2015 19:43:00 -0000
In-Reply-To: <20150805233318.21646.71143.stgit@valrhona.uglyboxes.com> (Keith	Seitz's message of "Wed, 05 Aug 2015 16:33:32 -0700")
Message-ID: <m3mvxzc4lp.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00227.txt.bz2

Keith Seitz <keiths@redhat.com> writes:
> * This patch has previously been approved. *
>
> This patch adds support for explicit locations to MI's -break-insert
> command. The new options, documented in the User Manual, are
> --source, --line, --function, and --label.
>
> gdb/ChangeLog:
>
> 	* mi/mi-cmd-break.c (mi_cmd_break_insert_1): Add support for
> 	explicit locations, options "--source", "--function",
> 	"--label", and "--line".
>
> gdb/testsuite/ChangeLog:
>
> 	* gdb.mi/mi-break.exp (test_explicit_breakpoints): New proc.
> 	(at toplevel): Call test_explicit_breakpoints.
> 	* gdb.mi/mi-dprintf.exp: Add tests for explicit dprintf
> 	breakpoints.
> 	* lib/mi-support.exp (mi_make_breakpoint): Add support for
> 	breakpoint conditions, "-cond".

Still approved.