From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74891 invoked by alias); 11 Mar 2016 09:24:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74881 invoked by uid 89); 11 Mar 2016 09:23:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:1242, H*o:Research X-HELO: e06smtp17.uk.ibm.com Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 11 Mar 2016 09:23:57 +0000 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Mar 2016 09:23:53 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 11 Mar 2016 09:23:52 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 46371219004D for ; Fri, 11 Mar 2016 09:23:34 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2B9NpVT63307962 for ; Fri, 11 Mar 2016 09:23:51 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2B9NpX6002465 for ; Fri, 11 Mar 2016 02:23:51 -0700 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2B9NoQY002452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Mar 2016 02:23:50 -0700 From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH] S390: Add use of unavailable-stack frame ID References: <56E1D869.3010006@redhat.com> Date: Fri, 11 Mar 2016 09:24:00 -0000 In-Reply-To: <56E1D869.3010006@redhat.com> (Pedro Alves's message of "Thu, 10 Mar 2016 20:26:17 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031109-0005-0000-0000-00000AC169F7 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00172.txt.bz2 On Thu, Mar 10 2016, Pedro Alves wrote: > On 03/07/2016 10:19 AM, Andreas Arnez wrote: >> When determining the frame ID of an inline frame, GDB currently asserts >> that a valid ID of the underlying real frame is found, and that it does >> not match outer_frame_id. From inline_frame_this_id(): >> >> /* For now, require we don't match outer_frame_id either (see >> comment above). */ >> gdb_assert (!frame_id_eq (*this_id, outer_frame_id)); >> >> However, this assertion may fail when the real frame's unwinder can not >> determine the frame ID. This happened on an s390x target with a binary >> that lacked call frame information and also confused the prologue >> analyzer, because then s390_frame_this_id() left the frame ID at its >> default. >> >> To fix this, this change enhances s390_frame_this_id such that an >> unavailable-stack frame ID is built if no frame base can be determined >> but the function address is available. >> > > Seeing all these makes me want this: > > https://sourceware.org/ml/gdb-patches/2016-02/msg00778.html > > even more. :-) Agreed. It's on Yao's todo list, right? ;-) -- https://sourceware.org/ml/gdb-patches/2016-02/msg00858.html -- Andreas