From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12687 invoked by alias); 13 May 2002 17:35:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12675 invoked from network); 13 May 2002 17:35:15 -0000 Received: from unknown (HELO dell-pe2450-3.cambridge.redhat.com) (195.224.55.225) by sources.redhat.com with SMTP; 13 May 2002 17:35:15 -0000 Received: from north-pole.nickc.cambridge.redhat.com (host217-35-6-237.in-addr.btopenworld.com [217.35.6.237]) by dell-pe2450-3.cambridge.redhat.com (Postfix) with ESMTP id D917585D89; Mon, 13 May 2002 18:35:14 +0100 (BST) Received: from north-pole.nickc.cambridge.redhat.com.nickc.cambridge.redhat.com (localhost [127.0.0.1]) by north-pole.nickc.cambridge.redhat.com (Postfix) with ESMTP id 4D4E81C395; Mon, 13 May 2002 18:35:05 +0100 (BST) To: thorpej@wasabisystems.com Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Include sh64 support for shle-*-netbsdelf* References: <20020511115603.W3435@dr-evil.shagadelic.org> <20020513082324.R3435@dr-evil.shagadelic.org> From: Nick Clifton Date: Mon, 13 May 2002 10:35:00 -0000 In-Reply-To: <20020513082324.R3435@dr-evil.shagadelic.org> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-05/txt/msg00477.txt.bz2 Hi Jason, > > > + shle-*-netbsdelf*) > > > + targ_defvec=bfd_elf32_shlnbsd_vec > > > + targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec" > > > +#ifdef BFD64 > > > + targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec" > > > +#endif > > > + ;; > > > sh*le-*-netbsdelf*) > > > targ_defvec=bfd_elf32_shlnbsd_vec > > > targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec" > > > > Doesn't the "sh*le-*-netbsdelf*" target (immediately below the lines > > you have added) already cover this situation ? > > It appears as if the intent in other configurations was to include sh64 > support only if the target was "sh", not "sh3" or "sh4", etc. Look down > one and two more, and you see the sh-*-netbsdelf* (added by hp when the > sh64 code went in) and the sh*-*-netbsdelf* (added by me when I checked > in NetBSD SH support) configs. Oh right, I understand now. In which case please consider this part of the patch approved too. Cheers Nick