From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14815 invoked by alias); 10 Nov 2009 22:23:28 -0000 Received: (qmail 14806 invoked by uid 22791); 10 Nov 2009 22:23:27 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Nov 2009 22:23:19 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMNIcn007270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Nov 2009 17:23:18 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMNHlc021713; Tue, 10 Nov 2009 17:23:18 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMNGLe016804; Tue, 10 Nov 2009 17:23:17 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 93B483782CF; Tue, 10 Nov 2009 15:23:16 -0700 (MST) From: Tom Tromey To: Sami Wagiaalla Cc: GDB Patches Subject: Re: [patch 1/2] Perform a namespace lookup at every block level References: <4A57512A.7090208@redhat.com> <20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> <4A68B91D.2080206@redhat.com> <4A8B0FBA.4090501@redhat.com> <4ADE21F9.7020801@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 10 Nov 2009 22:23:00 -0000 In-Reply-To: <4ADE21F9.7020801@redhat.com> (Sami Wagiaalla's message of "Tue, 20 Oct 2009 16:47:53 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00240.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> I have added shadowing.exp to the patch which belongs to a future Sami> patch but has some good tests, and it tests for the problem Sami> pointed out by Daniel. I also added Sami> namespace-multiple-imports.exp. Excuse the kfails; they will be Sami> fixed by a future patch. Thanks. Sami> +static struct symbol * Sami> +cp_lookup_symbol_in_namespace (const char *namespace, Sami> + const char *name, Sami> + const char *linkage_name, Sami> + const struct block *block, Sami> + const domain_enum domain) Sami> +{ Sami> + Extra blank line. Sami> +static struct symbol * Sami> +cp_lookup_symbol_imports (const char *scope, Sami> + const char *name, Sami> + const char *linkage_name, Sami> + const struct block *block, Sami> + const domain_enum domain) [...] Sami> + /* If the import destination is the current scope or one of its ancestors then Does this line go past column 80? It looks like it. Sami> + it is applicable. */ Sami> + if (strncmp (scope, current->import_dest, strlen (current->import_dest)) == 0) >From my reading this doesn't exactly match the comment -- can current->import_dest be an extension of scope? Like, if scope is "x" and import_dest is "xyz"? Sami> diff --git a/gdb/testsuite/gdb.cp/namespace-using.exp b/gdb/testsuite/gdb.cp/namespace-using.exp Sami> + return -1; No ";" here. Otherwise this looks good. Tom