From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2415 invoked by alias); 7 May 2010 16:40:36 -0000 Received: (qmail 2403 invoked by uid 22791); 7 May 2010 16:40:34 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 16:40:28 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47GePY3021012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 12:40:25 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47GeO4o008256; Fri, 7 May 2010 12:40:25 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o47GeN20010777; Fri, 7 May 2010 12:40:24 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 945FF378183; Fri, 7 May 2010 10:40:20 -0600 (MDT) From: Tom Tromey To: Paul Koning Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Make string printing work on NetBSD (iconv issue) References: <19424.30941.651367.946330@pkoning-laptop.equallogic.com> Reply-To: tromey@redhat.com Date: Fri, 07 May 2010 16:40:00 -0000 In-Reply-To: <19424.30941.651367.946330@pkoning-laptop.equallogic.com> (Paul Koning's message of "Tue, 4 May 2010 15:43:25 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00181.txt.bz2 >>>>> "Paul" == Paul Koning writes: Paul> The attached patch fixes this by having configure pick a suitable Paul> codeset name to use. "wchar_t" is used if available, otherwise ucs-2 Paul> or ucs-4 with the appropriate byte order suffix is used instead. This will yield incorrect results unless the chosen intermediate charset is actually the one used for wchar_t. Note that if this is the case for UCS-4, then your platform headers ought to define __STDC_ISO_10646__. So, you could test that in gdb_wchar.h rather than do any configury. Alternatively, it is always safe to fall back to the code that uses narrow intermediate characters and host_charset for the intermediate encoding. Perhaps this "wchar_t" thing is not the best way for us to go. Maybe better would be to test __STDC_ISO_10646__ and fall back to narrow chars in all other cases. Other approaches are available too, but they are generally more work than simply using GNU libiconv. Tom