From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30487 invoked by alias); 17 May 2010 16:37:36 -0000 Received: (qmail 30477 invoked by uid 22791); 17 May 2010 16:37:35 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 May 2010 16:37:31 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4HGbUcd024292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 May 2010 12:37:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4HGbUvL020882; Mon, 17 May 2010 12:37:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o4HGbTZD015310; Mon, 17 May 2010 12:37:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D2C5037818E; Mon, 17 May 2010 10:37:28 -0600 (MDT) From: Tom Tromey To: Andreas Schwab Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PR gdb/11092: Fix index overflow References: Reply-To: tromey@redhat.com Date: Mon, 17 May 2010 16:50:00 -0000 In-Reply-To: (Andreas Schwab's message of "Mon, 17 May 2010 18:06:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00352.txt.bz2 >>>>> "Andreas" == Andreas Schwab writes: Andreas> The length parameter of c_printstr can be -1 meaning NUL terminated. Andreas> Compute real length before its first use as an index. Andreas> 2010-05-17 Andreas Schwab Andreas> PR gdb/11092 Andreas> * c-lang.c (c_printstr): Compute real length of NUL terminated Andreas> string at first. This is ok. Thanks for fixing this. Tom