From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7616 invoked by alias); 27 Sep 2010 18:02:47 -0000 Received: (qmail 7608 invoked by uid 22791); 27 Sep 2010 18:02:47 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Sep 2010 18:02:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8RI2cFD024211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Sep 2010 14:02:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8RI2cXT025125; Mon, 27 Sep 2010 14:02:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8RI2bRS025048; Mon, 27 Sep 2010 14:02:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2BCA0378183; Mon, 27 Sep 2010 12:02:37 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix infinite loop crash on self-referencing class References: <20100924230028.GA24736@host1.dyn.jankratochvil.net> Date: Mon, 27 Sep 2010 19:07:00 -0000 In-Reply-To: <20100924230028.GA24736@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 25 Sep 2010 01:00:28 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00456.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-09-24 Jan Kratochvil Jan> Fix GDB crash on inferior calls with self-referencing classes. Jan> * gnu-v3-abi.c (gnuv3_pass_by_reference): Do not call itself on static Jan> member fields. This seems reasonable to me. Jan> + if (TYPE_FIELD_LOC_KIND (type, fieldnum) == FIELD_LOC_KIND_BITPOS There is a field_is_static convenience function you can use here. Tom