From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7786 invoked by alias); 23 Nov 2010 15:22:22 -0000 Received: (qmail 7763 invoked by uid 22791); 23 Nov 2010 15:22:20 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 15:22:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oANFLiYe015736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Nov 2010 10:21:44 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oANFLhu6009225; Tue, 23 Nov 2010 10:21:43 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oANFLgWN031887; Tue, 23 Nov 2010 10:21:42 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3EE12378885; Tue, 23 Nov 2010 08:21:42 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS) References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231242.44422.pedro@codesourcery.com> Date: Tue, 23 Nov 2010 15:22:00 -0000 In-Reply-To: <201011231242.44422.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 23 Nov 2010 12:42:44 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00352.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> /* With a Python scripting enabled GDB, store a reference to the Pedro> Python object that has been associated with this breakpoint. Pedro> This is always NULL for a GDB that is not script enabled. It Pedro> can sometimes be NULL for enabled GDBs as not all breakpoint Pedro> types are tracked by the Python scripting API. */ Pedro> PyObject *py_bp_object; Pedro> Given that we only need to hold a pointer to this, thus the PyObject Pedro> need not be complete at this point, can we forward declare PyObject Pedro> instead somehow? Python defines it as a typedef for "struct _object *". Yuck -- I'd rather not copy that into our code. Pedro> If not, can we perhaps come up with a wrapper type that itself Pedro> can be forward declared? Or fallback to void* if nothing else Pedro> cleaner is possible? Either of these works for me. Pedro> The advantage would be that python-internal.h would then only be Pedro> included in the specific modules that require it, in other words, Pedro> it would be moved to breakpoint.c. I think this would be good. Python has turned out to be unclean enough that it is better to work around its problems systematically. Tom