From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80510-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30302 invoked by alias); 21 Apr 2011 14:17:55 -0000
Received: (qmail 30292 invoked by uid 22791); 21 Apr 2011 14:17:55 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 14:17:36 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3LEHR1A030500	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 21 Apr 2011 10:17:27 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3LEHRuY003096;	Thu, 21 Apr 2011 10:17:27 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3LEHQvO028312;	Thu, 21 Apr 2011 10:17:26 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 6B08337808F; Thu, 21 Apr 2011 08:17:26 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Kevin Pouget <kevin.pouget@gmail.com>
Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
References: <BANLkTim4J5Nnt_bKQvcvHh+ve+jtQdkw8w@mail.gmail.com>	<m3ei4w21ay.fsf@fleche.redhat.com>	<BANLkTin90xSha-02=5NC=2BOkWio-5j=Rw@mail.gmail.com>	<201104210949.18831.pedro@codesourcery.com>
Date: Thu, 21 Apr 2011 14:17:00 -0000
In-Reply-To: <201104210949.18831.pedro@codesourcery.com> (Pedro Alves's	message of "Thu, 21 Apr 2011 09:49:18 +0100")
Message-ID: <m3liz3zo21.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00392.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> On Thursday 21 April 2011 09:11:29, Kevin Pouget wrote:
>> +               && b->number >= 0);

Pedro> Can you make those b->number > 0?   `0' is used for
Pedro> momentary breakpoints, which aren't user visible either.

I wonder if this code should be using user_breakpoint_p instead.

Tom