Re: [RFA] Improve performance with lots of shared libraries

[Tom Tromey <tromey@redhat.com>]

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> While working on a new linker-debugger interface I took some time out
Gary> to do a bit of profiling to see exactly where gdb is spending its time
Gary> with inferiors that load a lot of shared libraries, and it turned out
Gary> that the top 30% of the profile was update_section_map and the things
Gary> it calls.

Nice.

I think this will solve a problem I had:

    http://sourceware.org/ml/gdb-patches/2011-03/msg00606.html

I haven't committed that yet, but I will, sooner or later.

Gary> I'd really appreciate feedback from people who know this part of gdb
Gary> well, as well as feedback from those users who are using gdb on
Gary> many-solibs applications as to whether this patch helps.

I think Pedro is the person to review it.  The idea seems sound to me,
but as you note, this code is very dense.

I have a couple nits.

Gary> +/* Nonzero if the location stopoed at is the shlib event breakpoint.  */

Typo, "stopped".

Gary> +static int
Gary> +at_solib_event_breakpoint (struct execution_control_state *ecs)
Gary> +{
Gary> +  struct solib_event_breakpoint_helper_arg arg;
Gary> +  arg.prev_pc = ecs->event_thread->prev_pc;

Blank line between declarations and code.

Tom