From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19056 invoked by alias); 19 Jul 2011 16:26:27 -0000 Received: (qmail 19043 invoked by uid 22791); 19 Jul 2011 16:26:24 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jul 2011 16:26:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6JGQ5rh031298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jul 2011 12:26:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6JGQ5Tu025906; Tue, 19 Jul 2011 12:26:05 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6JGQ3PE006716; Tue, 19 Jul 2011 12:26:04 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 00/12] entryval: Fix x86_64 parameters, virtual tail call frames References: <20110718201344.GA30496@host1.jankratochvil.net> Date: Tue, 19 Jul 2011 16:39:00 -0000 In-Reply-To: <20110718201344.GA30496@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 18 Jul 2011 22:13:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00475.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> this is GDB side implementation of the DWARF-5.0 `entry values' Jan> extension: Thanks again for tackling this. Jan> Besides the new supported syntax `paramname@entry' no new user Jan> interaction is needed, everything just improves the user experience Jan> and makes -O2 -g debugging like -O0 -g debugging. In fact better Jan> thanks to the @entry values. I read all the patches and sent replies where I thought they were warranted. In particular I think patches 1, 3, 8, 9, and 12 are ok without additional comment. I noticed that you did not patch the DWARF->AX translator. If you'd rather not do this, or if it isn't possible, that is fine; the translator is already incomplete, simply because AX is not expressive enough. Tom