From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27027 invoked by alias); 4 Aug 2011 17:12:15 -0000 Received: (qmail 27018 invoked by uid 22791); 4 Aug 2011 17:12:13 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Aug 2011 17:11:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p74HBs9Z027010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Aug 2011 13:11:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p74HBrTY021723; Thu, 4 Aug 2011 13:11:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p74HBqcr022412; Thu, 4 Aug 2011 13:11:52 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [patch][python] Auto-load gdb.command and gdb.function modules References: Date: Thu, 04 Aug 2011 17:12:00 -0000 In-Reply-To: (Phil Muldoon's message of "Thu, 04 Aug 2011 17:52:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00075.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch enables module auto-importing for the gdb.command and Phil> gdb.function name-spaces. Any Python file (which is not __init__.py) Phil> located in {data-directory}/gdb/python/command and Phil> {data-directory}/gdb/python/function is now automatically imported, and Phil> available immediately upon GDB start. Phil> Tested on X86-64 with no regressions. Phil> OK? Phil> +module_dict = {\ Phil> +'gdb.function': os.path.join(gdb.PYTHONDIR, 'gdb', 'function'),\ Phil> +'gdb.command': os.path.join(gdb.PYTHONDIR, 'gdb', 'command')\ Phil> +} You don't need the trailing "\"s, please remove them. I think the lines in the dict should be indented, that looks better. Phil> + py_files = filter(lambda x: x.endswith('.py') and x != '__init__.py',\ Phil> + os.listdir(location)) Indentation of the second line looks wrong. I don't think you need that "\". Phil> + for py_file in py_files: Phil> + py_file = py_file.rstrip('.py') Phil> + py_file = module + '.' + py_file Phil> + try: Phil> + exec('import ' + py_file) Phil> + except: Phil> + print 'Error importing: ', py_file It seems like this should print the real error from the exception. Tom