From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5214 invoked by alias); 2 Nov 2011 19:06:27 -0000 Received: (qmail 5205 invoked by uid 22791); 2 Nov 2011 19:06:26 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 19:06:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2J5jPw010417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Nov 2011 15:05:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA2J5itK027815; Wed, 2 Nov 2011 15:05:44 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2J5g4g002725; Wed, 2 Nov 2011 15:05:42 -0400 From: Tom Tromey To: iam ahal Cc: gdb-patches@sourceware.org, eliz@gnu.org, pmuldoon@redhat.com, brobecker@adacore.com, pedro@codesourcery.com, drow@false.org, jan.kratochvil@redhat.com Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) References: <20110627160029.GF20676@adacore.com> <834o33qlm9.fsf@gnu.org> <83bowq6x7f.fsf@gnu.org> Date: Wed, 02 Nov 2011 19:06:00 -0000 In-Reply-To: (iam ahal's message of "Sun, 30 Oct 2011 21:16:31 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00051.txt.bz2 >>>>> "Eldar" == iam ahal writes: Eldar> Copyright assignment by [gnu.org #703515] is completed. Eldar> I've corrected some pieces of the patch by your notes. Eldar> Also, I've attached the change log. Thanks. Eldar> diff -rup gdb-7.3.1-orig/gdb/doc/gdb.texinfo gdb-7.3.1/gdb/doc/gdb.texinfo I don't recall whether this has had a doc review yet. I think the patch should also include a NEWS entry. Eldar> +@item set backtrace filename-display basename Eldar> +Display only basename of a filename. Eldar> + Eldar> +@item set backtrace filename-display basename Eldar> +Display a filename without the compile directory part. "basename" is repeated; I think the second one should be without-compile-directory. Eldar> + const char *filename_display = get_filename_display_from_sal (&sal); Eldar> + if (filename_display == NULL) Blank line between these two lines. Eldar> 2011-10-30 Eldar Gaynetdinov Eldar> Add a new variable that controls a way in which filenames in Eldar> backtraces is displayed. Eldar> * gdb.texinfo: Added description of 'filename-display' variable in Eldar> 'set/show backtrace' section. doc/ has its own ChangeLog, so this entry must go there. Otherwise looks good, I think one more revision + doc review and it is ready. Tom