From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1851 invoked by alias); 16 Dec 2011 19:29:45 -0000 Received: (qmail 1840 invoked by uid 22791); 16 Dec 2011 19:29:43 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Dec 2011 19:29:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBGJT4Jo008756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Dec 2011 14:29:04 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBGJT3rE021738; Fri, 16 Dec 2011 14:29:03 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBGJT1T1021274; Fri, 16 Dec 2011 14:29:01 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] Add handling for unqualified Ada operators in linespecs References: <1323810763-5563-1-git-send-email-brobecker@adacore.com> Date: Fri, 16 Dec 2011 19:32:00 -0000 In-Reply-To: <1323810763-5563-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Tue, 13 Dec 2011 16:12:43 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00533.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> This patch enhances the linespec parser to recognize unqualified Joel> operator names in linespecs. This allows the user to insert a breakpoint Joel> on operator "+" as follow, for instance: Joel> (gdb) break "+" I think it is fine to allow this. I wonder whether this requires a documentation change. Joel> Not the most elegant solution, but relatively self contained. So Joel> I thought I'd submit it, after all. It's still not completely Joel> functional because, for it to work, it needs the symtabs to be Joel> already read-in (or, in other words, the partial symbol search is Joel> still not working). But that's actually another, much more general Joel> problem, which is related to breakpoints using unqualified function Joel> names in general. I will try to think about that on its own. I think we should continue trying to look at solutions to linespec and symbol table problems in as language-independent a way as possible. And, if we can't be language-independent, we should endeavor to have clean code; the current stuff is still a big mess. I think Keith's changes will help some here... Joel> + p = *argptr; Joel> + if (p[0] == '"' Why only double quotes? I don't even mind that as a temporary measure. But I think (or hope) Keith's plan is for single- and double-quotes to be considered identically, and uniformly, throughout linespec. Tom