From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Remove wrapper.[ch]
Date: Mon, 09 Jan 2012 16:22:00 -0000 [thread overview]
Message-ID: <m3lipgsv62.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F076E33.1030404@redhat.com> (Keith Seitz's message of "Fri, 06 Jan 2012 13:57:07 -0800")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> libgdb is history. The introduction of TRY_CATCH is now the standard
Keith> way to do these sorts of tasks. There seems little point to support
Keith> yet another ancient/nearly unused API to gdb's internals.
I agree. This patch is ok.
You might want to look at removing gdb_rc entirely. There are only a
few more uses; and it seems pointless to me to have a second generic,
high-level way to deal with error cases; exceptions are enough for this.
(I don't discount the use of having error returns rather than exceptions
for specific APIs.) You could then perhaps remove gdb.h as well.
Tom
next prev parent reply other threads:[~2012-01-09 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 21:57 Keith Seitz
2012-01-09 16:22 ` Tom Tromey [this message]
2012-01-09 20:29 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lipgsv62.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox