From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8574 invoked by alias); 30 Jan 2012 19:58:29 -0000 Received: (qmail 8562 invoked by uid 22791); 30 Jan 2012 19:58:28 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jan 2012 19:58:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0UJvsZY014066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 Jan 2012 14:57:54 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0UJvsL9002680; Mon, 30 Jan 2012 14:57:54 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0UJvq5Q021747; Mon, 30 Jan 2012 14:57:53 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] GDB/MI: crash printing "_task" (Ada) argument References: <1327906636-20099-1-git-send-email-brobecker@adacore.com> Date: Mon, 30 Jan 2012 20:07:00 -0000 In-Reply-To: <1327906636-20099-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 30 Jan 2012 10:57:16 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00999.txt.bz2 Joel> - sym2 = lookup_symbol (SYMBOL_NATURAL_NAME (sym), Joel> + sym2 = lookup_symbol (SYMBOL_SEARCH_NAME (sym), Oops. Actually, I looked closer, and iterate_over_block_arg_vars uses SYMBOL_LINKAGE_NAME. Either that is a latent bug, or I think your patch should follow it in the same of consistency. Tom