From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12734 invoked by alias); 24 Apr 2012 18:11:29 -0000 Received: (qmail 12717 invoked by uid 22791); 24 Apr 2012 18:11:28 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 18:11:08 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OIB8Zk021099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 14:11:08 -0400 Received: from psique (ovpn-112-42.phx2.redhat.com [10.3.112.42]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OIB4wv016032; Tue, 24 Apr 2012 14:11:06 -0400 From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Refactor observer.sh to cleanup unused vars References: <87ipgpdnam.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Tue, 24 Apr 2012 18:11:00 -0000 In-Reply-To: <87ipgpdnam.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 24 Apr 2012 11:58:41 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00820.txt.bz2 On Tuesday, April 24 2012, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> + if test ! -z ${notify_args}; then > > I think there should be double quotes here, like "${notify_args}". > > Ok with that change. Thanks. Committed with that change. http://sourceware.org/ml/gdb-cvs/2012-04/msg00194.html -- Sergio