From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30576 invoked by alias); 7 Nov 2013 07:11:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30503 invoked by uid 89); 7 Nov 2013 07:11:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mail-pd0-f181.google.com Received: from Unknown (HELO mail-pd0-f181.google.com) (209.85.192.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Nov 2013 07:11:00 +0000 Received: by mail-pd0-f181.google.com with SMTP id x10so184364pdj.12 for ; Wed, 06 Nov 2013 23:10:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=6spbcT/3j3Tq7NbP1yIa3l7k77mOUTjsdzg03jLJIpI=; b=g1XfYhTZsApARS0axEBiAm98erBHE+oKnis0aixPsq3QjNSpnWfCBHRxedh4luWl6g bFe31zz08eAifzl0kZxlNOLcsS1FtUfVmtf5B5fHkg+jxKgGNNO5ukPHvVHe28KAKeXV Y0moJjhq6YOPQm7lYNrcy/uMabFghyASsLKWY2PdIhABPxMn5W0UhAEPSGwDe+FkBtrP 2khQnb8oK/vmCIMu7+RYFhkp7PW1m6i+rPNbppWL5qssGX179yEeFbbMxppkDsrE913d nc9B+QGD9qx+ResO/EEjapAD0hb2yTo2S9M6LYv+3cMCB7LSaanh6ESnXK3OnUsT7dbm a33g== X-Gm-Message-State: ALoCoQl5vhUWEOGcl75tTEN3tLZ4EVZMJbEvQIz/7P4zINCsccNA1HB6xJ89ME1+etYpi/YOMXQN X-Received: by 10.68.185.68 with SMTP id fa4mr7563362pbc.136.1383808252431; Wed, 06 Nov 2013 23:10:52 -0800 (PST) Received: from seba.sebabeach.org.sebabeach.org (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id rp8sm2799280pbc.25.2013.11.06.23.10.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2013 23:10:51 -0800 (PST) From: Doug Evans To: Tom Tromey Cc: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c References: <527AB482.80600@earthlink.net> <87ppqd1a0t.fsf@fleche.redhat.com> Date: Thu, 07 Nov 2013 07:17:00 -0000 In-Reply-To: <87ppqd1a0t.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 06 Nov 2013 14:43:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00163.txt.bz2 Tom Tromey writes: > Stan> +/* A helper function for tyscm_richcompare that checks two types for > Stan> + "deep" equality. Returns non-zero if the types are considered the > Stan> + same, zero otherwise. */ > > Stan> "tyscm_richcompare"? Should that be typy_... ? > > It would be helpful if Doug could list all the change he made when > moving the code. I don't understand. Which changes? While useful beyond its present state, this is in essence just a cleanup.