From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17254 invoked by alias); 28 Nov 2007 22:50:18 -0000 Received: (qmail 17246 invoked by uid 22791); 28 Nov 2007 22:50:17 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Nov 2007 22:50:10 +0000 Received: (qmail 29489 invoked from network); 28 Nov 2007 22:50:09 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Nov 2007 22:50:09 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Don't reset watchpoint block on solib load. References: <200711202013.47537.vladimir@codesourcery.com> <200711281858.51145.vladimir@codesourcery.com> <200711282304.16403.vladimir@codesourcery.com> From: Jim Blandy Date: Wed, 28 Nov 2007 22:50:00 -0000 In-Reply-To: <200711282304.16403.vladimir@codesourcery.com> (Vladimir Prus's message of "Wed, 28 Nov 2007 23:04:16 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00534.txt.bz2 Vladimir Prus writes: >> Should we instead be saving the PC in whose scope we parsed the >> expression? That's something we could legitimately look up in >> breakpoint_re_set_one after a symbol table change. The test in >> watchpoint_check could look up the PC's function and compare it to the >> frame's function. > > Well, it does not work with address randomization. And I think that for > global watchpoints, just re-parsing the expression works good > enough. Address randomization is a good point. I think we should still be able to get the right behavior somehow, though.