From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6563 invoked by alias); 22 Oct 2008 20:15:07 -0000 Received: (qmail 6537 invoked by uid 22791); 22 Oct 2008 20:15:07 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Oct 2008 20:14:32 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9MKCeKp023758; Wed, 22 Oct 2008 16:12:40 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9MKCd9S019040; Wed, 22 Oct 2008 16:12:39 -0400 Received: from opsy.redhat.com (vpn-13-67.rdu.redhat.com [10.11.13.67]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m9MKCbcb016617; Wed, 22 Oct 2008 16:12:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C99EE378701; Wed, 22 Oct 2008 14:12:36 -0600 (MDT) To: Joel Brobecker Cc: Ulrich Weigand , Thiago Jung Bauermann , gdb-patches@sourceware.org Subject: Re: [RFC/RFA] add struct parse_context to all command functions References: <20081021004630.GA6571@caradoc.them.org> <200810211805.m9LI5Lt0014410@d12av02.megacenter.de.ibm.com> <20081021181739.GA10391@caradoc.them.org> <20081022014000.GA3638@adacore.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Wed, 22 Oct 2008 20:15:00 -0000 In-Reply-To: <20081022014000.GA3638@adacore.com> (Joel Brobecker's message of "Tue\, 21 Oct 2008 18\:40\:00 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00554.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I think it will depend on each global. For the current_language and Joel> the input_radix, my goal is to have it used only from the command line Joel> loop that calls the command functions. Though there is a little wart, namely that the set and show commands must refer to the globals directly. Joel> I will wait another couple of days to see how people react, but it Joel> seems at this point that everyone was OK with approach (1), where Joel> I do the transition all in one go. And since Tom was the lead Joel> "questioner" of this change, I'd like to mention that my understanding Joel> is that Tom understands the benefits of adding the extra parameter, Joel> given the above explaination. Tom, please yell if I misunderstood you! I still think the benefits are mild, at best, but I don't want to stop your gusto. I don't think this change will make gdb worse. Tom