Re: [patch][python] Implement Python lazy strings (PR 10705)

Eli Zaretskii
2010-01-11T19:10:35Z

> Date: Mon, 11 Jan 2010 15:39:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
>
> Thanks for the review. I've updated the patch in accordance with your
> requests. How does this look?

It's good to go, but please fix one small error in usage of Texinfo:

> +the string type. For further information on encoding in @value{GDBN}
> +please see: @pxref{Character Sets}.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
You want "see @ref{Character Sets}." here. @pxref is for
cross-references that you put in parentheses.

> +@pxref{Types In Python}. This attribute is not writable.

Two spaces, please.

Thanks.