From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70881-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17888 invoked by alias); 8 Mar 2010 18:58:54 -0000
Received: (qmail 17880 invoked by uid 22791); 8 Mar 2010 18:58:54 -0000
X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Mar 2010 18:58:50 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o28IwmqP005989 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Mon, 8 Mar 2010 13:58:48 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o28IwlBX009260; 	Mon, 8 Mar 2010 13:58:47 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o28Iwkhl031417; 	Mon, 8 Mar 2010 13:58:47 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 890E13782A7; Mon,  8 Mar 2010 11:58:46 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Add support for imported declaration and correct search order
References: <4B86DA17.5040200@redhat.com> 	<20100225224145.GA21231@host0.dyn.jankratochvil.net> 	<m3y6ifn4fo.fsf@fleche.redhat.com> <4B8ED7C2.6030804@redhat.com> 	<m38wa93w28.fsf@fleche.redhat.com> <4B952743.4000501@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Mon, 08 Mar 2010 18:58:00 -0000
In-Reply-To: <4B952743.4000501@redhat.com> (Sami Wagiaalla's message of "Mon, 	08 Mar 2010 11:35:15 -0500")
Message-ID: <m3k4tmtzbt.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00326.txt.bz2

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> +          && ((!declaration && !current->declaration)
Sami> +              || strcmp (current->declaration, declaration) == 0))

I think this check is wrong in the same way as the alias check in the
previous patch.

Tom