From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70940-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24826 invoked by alias); 10 Mar 2010 16:34:30 -0000
Received: (qmail 24812 invoked by uid 22791); 10 Mar 2010 16:34:29 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Mar 2010 16:34:21 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2AGYJaw006344 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Wed, 10 Mar 2010 11:34:19 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2AGYJWF015523; 	Wed, 10 Mar 2010 11:34:19 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2AGYICp009567; 	Wed, 10 Mar 2010 11:34:18 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id AA909378267; Wed, 10 Mar 2010 09:34:17 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [2/2] RFC: let "commands" affect multiple breakpoints
References: <m31vfsltl7.fsf@fleche.redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Wed, 10 Mar 2010 16:34:00 -0000
In-Reply-To: <m31vfsltl7.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 	09 Mar 2010 20:54:28 -0700")
Message-ID: <m3k4tkjfue.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00385.txt.bz2

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I'd appreciate comments on this.  Barring comments I will commit it
Tom> soonish.  It needs a doc review.

Actually, this patch is a little half-baked.  I forgot (sigh) to write
any tests... so I won't be committing it until I do that.

I do have a question though.  With this change, gdb prints somewhat less
nice text for "commands":

Tom> +	l = read_command_lines (_("Type commands for all specified breakpoints"),
Tom> +				info->from_tty, 1);

Tom> -	char *tmpbuf = xstrprintf ("Type commands for when breakpoint %d is hit, one per line.", 
Tom> -				 bnum);

Any suggestions for something better here?

Tom