From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5836 invoked by alias); 15 Mar 2010 20:25:14 -0000 Received: (qmail 5826 invoked by uid 22791); 15 Mar 2010 20:25:14 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Mar 2010 20:25:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2FKP8sv016678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Mar 2010 16:25:08 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2FKP89A024855; Mon, 15 Mar 2010 16:25:08 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2FKP7mi022850; Mon, 15 Mar 2010 16:25:07 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3C8CB378261; Mon, 15 Mar 2010 14:25:07 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: FYI: fix PR 9708 References: <20100313023630.GA29285@caradoc.them.org> <20100315201121.GA7450@caradoc.them.org> Reply-To: Tom Tromey Date: Mon, 15 Mar 2010 20:25:00 -0000 In-Reply-To: <20100315201121.GA7450@caradoc.them.org> (Daniel Jacobowitz's message of "Mon, 15 Mar 2010 16:11:27 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00561.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Tom> Yes, I think we should also omit DW_TAG_subprogram here. I just didn't Tom> think of it. I can either just check it in, or if you have an easy way Tom> to test it, let me know. I've appended the patch. Daniel> The patch looks good to me; would you mind committing it? I'll commit it shortly, here is the ChangeLog entry: 2010-03-15 Tom Tromey * dwarf2read.c (die_needs_namespace): Also return 0 for DW_TAG_subprogram. Tom> opsy. nm pr | grep themagicstatic Tom> 080497de V _ZZN1K1mEvE14themagicstatic Tom> 080497dd V _ZZN1K1mEvE14themagicstatic_0 Daniel> For added amusement pipe that to c++filt. They demangle the same. Daniel> Doesn't that seem like a bug? Yeah, though printing the _0 form would also be weird. Strange situation. Tom