From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3400 invoked by alias); 9 Apr 2010 18:45:21 -0000 Received: (qmail 3382 invoked by uid 22791); 9 Apr 2010 18:45:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 18:45:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39IjFvI021895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 9 Apr 2010 14:45:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39IjD6F002786; Fri, 9 Apr 2010 14:45:13 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o39IjC83008084; Fri, 9 Apr 2010 14:45:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 7461C379786; Fri, 9 Apr 2010 12:45:12 -0600 (MDT) From: Tom Tromey To: Ozkan Sezer Cc: gdb-patches@sources.redhat.com Subject: Re: PING: [PATCH] properly check error return from socket() and accept() calls References: Reply-To: tromey@redhat.com Date: Fri, 09 Apr 2010 18:45:00 -0000 In-Reply-To: (Ozkan Sezer's message of "Wed, 7 Apr 2010 09:39:17 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00274.txt.bz2 >>>>> "Ozkan" == Ozkan Sezer writes: Ozkan> PING. Ozkan> 2010-04-03 Ozkan Sezer Ozkan> gdb/ Ozkan> * ser-tcp.c (net_open): Check error return from socket() call by its Ozkan> equality to -1 not by it being negative. Ozkan> (net_close): Likewise. [...] It seems reasonable enough to me. Do you have a copyright assignment in place? TBH it isn't clear to me whether this patch requires one -- it is long enough, but I would say that there is really only one way to write this patch. Tom