From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72112-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32123 invoked by alias); 13 Apr 2010 21:09:12 -0000
Received: (qmail 32044 invoked by uid 22791); 13 Apr 2010 21:09:11 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 21:09:04 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3DL92LQ003713 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Tue, 13 Apr 2010 17:09:03 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3DL92uG005358; 	Tue, 13 Apr 2010 17:09:02 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3DL91QA029598; 	Tue, 13 Apr 2010 17:09:01 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 54864378887; Tue, 13 Apr 2010 15:09:01 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] PR pyton/11381
References: <4BBE1073.40703@redhat.com> <m3iq80ocdu.fsf@fleche.redhat.com> 	<4BC4882C.8060601@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 13 Apr 2010 21:09:00 -0000
In-Reply-To: <4BC4882C.8060601@redhat.com> (Phil Muldoon's message of "Tue, 13 	Apr 2010 16:05:16 +0100")
Message-ID: <m3k4sb9i1e.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00431.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I'm not sure what to do in the 'to_string' returns 'None' and the
Phil> missing 'children' method above.

I think it is fine as-is.  People just shouldn't do this, just like they
shouldn't write printers that fail in other weird ways.

This patch is ok.  Thanks.

Tom