From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15169 invoked by alias); 23 Nov 2010 20:41:10 -0000 Received: (qmail 15159 invoked by uid 22791); 23 Nov 2010 20:41:09 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 20:40:55 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oANKepf4028552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Nov 2010 15:40:51 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oANKeorG022222; Tue, 23 Nov 2010 15:40:50 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oANKeoKp031446; Tue, 23 Nov 2010 15:40:50 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id BD20C378885; Tue, 23 Nov 2010 13:40:49 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: Doug Evans , gdb-patches@sourceware.org, Ian Lance Taylor Subject: Re: [patch] Support -fsplit-stack (previous frame inner to this frame) References: <20101123001325.GA11983@host0.dyn.jankratochvil.net> <20101123021159.GA19258@host0.dyn.jankratochvil.net> Date: Tue, 23 Nov 2010 20:41:00 -0000 In-Reply-To: <20101123021159.GA19258@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 23 Nov 2010 03:11:59 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00372.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> + /* Start and end of the `__morestack' function. MORESTACK_END address is Jan> + the end plus one (exclusive) one. */ One of the "one"s seems redundant. Jan> + CORE_ADDR morestack_start, morestack_end; Is it impossible for __morestack to appear in multiple objfiles? What if you have a program that dlmopen()s two versions of the shared library defining it? I don't know how strict we want to be about this kind of thing -- we don't actually support dlmopen in any meaningful way right now anyway. I think this would also need to hook into objfile_relocate. A new frame type seems like an ok idea. I don't mind this approach, though I'm also interested to hear what others think. Tom