From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7331 invoked by alias); 2 Dec 2010 16:14:53 -0000 Received: (qmail 7320 invoked by uid 22791); 2 Dec 2010 16:14:52 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Dec 2010 16:14:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB2GEkKp026167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Dec 2010 11:14:46 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB2GEk7P026059; Thu, 2 Dec 2010 11:14:46 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oB2GEjpK002289; Thu, 2 Dec 2010 11:14:45 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6178037817D; Thu, 2 Dec 2010 09:14:45 -0700 (MST) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Cleanup in find_method References: <4CF6D1E3.6070709@redhat.com> Date: Thu, 02 Dec 2010 16:14:00 -0000 In-Reply-To: <4CF6D1E3.6070709@redhat.com> (Keith Seitz's message of "Wed, 01 Dec 2010 14:53:23 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00013.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I've also taken a small liberty, adding a cleanup for it, just in case Keith> something freaky happens inside find_function_start_sal. I don't think Keith> that this function can fail in this specific case, but call me Keith> paranoid. It doesn't hurt. Keith> Comments? This is ok. Tom