From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27784 invoked by alias); 1 Mar 2011 17:15:54 -0000 Received: (qmail 27772 invoked by uid 22791); 1 Mar 2011 17:15:52 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,TW_GT,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 17:15:47 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p21HFh36028021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 1 Mar 2011 12:15:43 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p21HFghG029477; Tue, 1 Mar 2011 12:15:43 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p21HFfQx018134; Tue, 1 Mar 2011 12:15:42 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id A55A73785EB; Tue, 1 Mar 2011 10:15:41 -0700 (MST) From: Tom Tromey To: Andreas Schwab Cc: gdb-patches@sourceware.org Subject: Re: RFC: remove a bunch of testsuite/**/configure scripts References: Date: Tue, 01 Mar 2011 17:15:00 -0000 In-Reply-To: (Andreas Schwab's message of "Mon, 28 Feb 2011 23:09:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00033.txt.bz2 Tom> I omitted the removed files from the appended. Andreas> You omitted the change to configure.ac as well. Whoops. I've appended that part. Tom> * configure.ac: Don't AC_CONFIG_HEADER in gdb.hp or gdb.stabs. Andreas> s/AC_CONFIG_HEADER/AC_CONFIG_SUBDIRS/ Tom> Remove stabs-specific logic. Test for existence of ../gdbtk Tom> before configuring gdb.gdbtk. Build Makefiles in gdb.hp Tom> subdirectories and gdb.stabs. Andreas> + gdb.cell? Thanks, I updated this part of the entry to read: * configure.ac: Don't AC_CONFIG_SUBDIRS in gdb.hp or gdb.stabs. Remove stabs- and cell-specific logic. Test for existence of ../gdbtk before configuring gdb.gdbtk. Build Makefiles in gdb.hp subdirectories, gdb.cell, and and gdb.stabs. Tom diff --git a/gdb/testsuite/configure.ac b/gdb/testsuite/configure.ac index 9f96f95..8631442 100644 --- a/gdb/testsuite/configure.ac +++ b/gdb/testsuite/configure.ac @@ -37,60 +37,10 @@ esac AM_CONDITIONAL(GMAKE, test "$MAKE_IS_GNU" = yes) AC_PROG_MAKE_SET -# Add HP-specific tests when appropriate. -case $target in - hppa*-*-hpux*) - AC_CONFIG_SUBDIRS(gdb.hp) ;; -esac - -# Add Cell/B.E. specific tests when appropriate. -# We need support for both PowerPC and SPU targets configured in. -case $target in - powerpc*-*-linux*) - have_spu_target=no - for targ in `echo $enable_targets | sed 's/,/ /g'` - do - case "${targ}" in - spu*|all) have_spu_target=yes ;; - esac - done - if test x$have_spu_target = xyes; then - AC_CONFIG_SUBDIRS(gdb.cell) - fi - ;; -esac - -# With stabs. -AC_ARG_WITH(stabs, -[ --with-stabs arrange to use stabs instead of host debug format],, -[# We enable stabs tests by default on selected targets. -case $target in - powerpc-*-aix* \ - | rs6000-*-aix* \ - | *-*-*bsd* \ - | *-*-go32* \ - | *-*-linux* \ - | *-*-lynxos* \ - | *-sun-* \ - | hppa*-*-* \ - | *-*-elf* \ - | *-*-cygwin* \ - | *-*-mingw* \ - ) - with_stabs=yes ;; - *) - with_stabs=no ;; -esac]) - -# Add stabs tests when appropriate. -if test $with_stabs = yes; then - AC_CONFIG_SUBDIRS(gdb.stabs) -fi - # Enable gdbtk. AC_ARG_ENABLE(gdbtk, [ --enable-gtk enable gdbtk graphical user interface (GUI)],, - [if test -d $srcdir/gdb.gdbtk; then + [if test -d $srcdir/../gdbtk && test -d $srcdir/gdb.gdbtk; then enable_gdbtk=yes else enable_gdbtk=no @@ -141,9 +91,12 @@ AC_EXEEXT AC_OUTPUT([Makefile \ gdb.ada/Makefile \ gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \ - gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \ + gdb.cell/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \ gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile \ + gdb.hp/Makefile gdb.hp/gdb.objdbg/Makefile gdb.hp/gdb.base-hp/Makefile \ + gdb.hp/gdb.aCC/Makefile gdb.hp/gdb.compat/Makefile \ + gdb.hp/gdb.defects/Makefile \ gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile \ gdb.objc/Makefile gdb.opencl/Makefile gdb.opt/Makefile gdb.pascal/Makefile \ - gdb.python/Makefile gdb.reverse/Makefile \ + gdb.python/Makefile gdb.reverse/Makefile gdb.stabs/Makefile \ gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile])