From: Phil Muldoon <pmuldoon@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Prompt memory management/cleanups
Date: Wed, 20 Jul 2011 15:06:00 -0000 [thread overview]
Message-ID: <m3k4bduh73.fsf@redhat.com> (raw)
In-Reply-To: <201107201543.12940.pedro@codesourcery.com> (Pedro Alves's message of "Wed, 20 Jul 2011 15:43:12 +0100")
Pedro Alves <pedro@codesourcery.com> writes:
> On Wednesday 20 July 2011 15:30:19, Phil Muldoon wrote:
>> s = get_prompt (0)
>> set_prompt (s, 0)
>>
>> Without that check, 'PROMPT (level)' would be freed, but 's' points to
>> that. So you set garbage. get_prompt returns a pointer, not a copy.
>
> I'm probably missing something, but isn't it just
> a matter of instead of having:
>
> + xfree (PROMPT (level));
> + PROMPT (level) = xstrdup (s);
>
> you have:
>
> + char *newp = xstrdup (s);
> + xfree (PROMPT (level));
> + PROMPT (level) = newp;
>
> ?
Yeah I noted we could do that in my reply. Sure we can do that, I'm not
opposed to it. But I am not sure on your objection to the check we make
first instead of the xstrdup? If PROMPT (level) == s, then there is no
need to copy the contents of s into PROMPT, it is already there? The
user is effectively asking for a noop?
Cheers,
Phil
next prev parent reply other threads:[~2011-07-20 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 13:46 Phil Muldoon
2011-07-20 14:30 ` Pedro Alves
2011-07-20 14:37 ` Phil Muldoon
2011-07-20 15:01 ` Pedro Alves
2011-07-20 15:06 ` Phil Muldoon [this message]
2011-07-20 15:15 ` Pedro Alves
2011-07-20 15:45 ` Tom Tromey
2011-07-20 16:04 ` Pedro Alves
2011-07-20 16:06 ` Tom Tromey
2011-07-20 15:05 ` Tom Tromey
2011-07-20 15:21 ` Phil Muldoon
2011-07-20 15:35 ` Tom Tromey
2011-07-21 17:15 ` Phil Muldoon
2011-07-21 20:42 ` Tom Tromey
2011-07-22 13:26 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4bduh73.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox