From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7637 invoked by alias); 28 Oct 2011 18:14:10 -0000 Received: (qmail 7600 invoked by uid 22791); 28 Oct 2011 18:14:07 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Oct 2011 18:13:50 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9SIDhxP006902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Oct 2011 14:13:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9SIDhdC005563; Fri, 28 Oct 2011 14:13:43 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9SIDfvb012920; Fri, 28 Oct 2011 14:13:41 -0400 From: Tom Tromey To: Justin Lebar Cc: Eli Zaretskii , Stan Shebs , gdb-patches@sourceware.org Subject: Re: Status of 'blacklist' patch? References: <4E8DCE67.80507@earthlink.net> <4E92E639.7000402@earthlink.net> <83ipnjs9i1.fsf@gnu.org> <83ipndc92n.fsf@gnu.org> <83ehy0ded8.fsf@gnu.org> <4EA753C4.60408@mentor.com> Date: Fri, 28 Oct 2011 18:18:00 -0000 In-Reply-To: (Justin Lebar's message of "Wed, 26 Oct 2011 11:06:22 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00772.txt.bz2 >>>>> "Justin" == Justin Lebar writes: Justin> Thanks for the testing advice; I ran the test many times on my Justin> machine, and it now works without error every time. Justin> New roll-up patch is attached. The only difference from v4 is Justin> in skip.exp. Thanks for persevering. Your test cases seem nicely comprehensive; thanks for making the extra effort. I think one more iteration; I would approve-it-with-changes but there is one non-cosmetic issue. It isn't too major. Justin> +/* Attempt to determine architecture of location identified by SAL. */ Justin> +extern struct gdbarch * Justin> +get_sal_arch (struct symtab_and_line sal); In a case like this, indent the continuation line a bit. Justin> + TRY_CATCH (decode_exception, NOT_FOUND_ERROR) The second argument to TRY_CATCH actually must be one of the RETURN_MASK_* constants. Here I suggest RETURN_MASK_ERROR. Justin> + if (decode_exception.reason < 0) Justin> + { Then here you can: if (decode_exception.reason < 0) { if (decode_exception.error != NOT_FOUND_ERROR) throw_exception (decode_exception); ... Justin> + ALL_SKIPLIST_ENTRIES (e) Justin> + if (arg == 0 || number_is_in_list(arg, e->number)) Space before the open paren. Justin> + if (arg != 0 && !number_is_in_list(arg, e->number)) Likewise. This appears in a few more places -- all uses of number_is_in_list. Justin> +/* Create a skiplist entry for the given pc corresponding to the given Justin> + function name and add it to the list. */ Justin> +static void Justin> +skip_function_pc (CORE_ADDR pc, char *name, struct gdbarch *arch, Blank line between intro comment and the start of the function. I think there are a few instances of this. Justin> +gdb_start Justin> +gdb_load ${binfile_main} Use clean_restart here instead. Justin> +gdb_test "skip file ${srcfile_lib}" \ Justin> +"File ${srcfile_lib} will be skipped when stepping." \ Justin> +"ignoring file in solib" \ Justin> +"No source file named ${srcfile_lib}.* Justin> +Ignore file pending future shared library load.*"\ Justin> +"y" Code like this is more readable if you indent the continuation lines. I realize this can't be done for every line here, and that is ok -- but the lines following a "\" should be indented. There should be a space before the last "\". Justin> +gdb_test "info skip" \ Justin> +"Num\\s+Type\\s+Enb\\s+Address\\s+What\\s* Justin> +1\\s+file\\s+y\\s+\\s+${srcfile_lib} \\(PENDING\\)\\s*" \ Justin> +"info skip with pending file" Indentation. Justin> +gdb_test "info skip" \ Justin> +"Num\\s+Type\\s+Enb\\s+Address\\s+What\\s* Justin> +1\\s+file\\s+y\\s+\\s+.*${srcfile_lib}\\s*" \ Justin> +"info skip with pending file" Indentation. There are a few more of these. Justin> +gdb_exit Justin> +gdb_start Justin> +gdb_load ${binfile_main} clean_restart Tom