From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11802 invoked by alias); 7 Nov 2011 14:55:22 -0000 Received: (qmail 11792 invoked by uid 22791); 7 Nov 2011 14:55:21 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 14:54:34 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA7EsVYe020403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Nov 2011 09:54:31 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA7EsUGd025392; Mon, 7 Nov 2011 09:54:31 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA7EsS8s003811; Mon, 7 Nov 2011 09:54:29 -0500 From: Tom Tromey To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [patch] Run tests in gdb.reverse References: <4EB69AE6.4010301@codesourcery.com> Date: Mon, 07 Nov 2011 14:55:00 -0000 In-Reply-To: <4EB69AE6.4010301@codesourcery.com> (Yao Qi's message of "Sun, 06 Nov 2011 22:34:14 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00150.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> During reviewing "arm reverse debugging" patch, we realize that tests in Yao> gdb.reverse are not run in common regression test unless we set some Yao> variables in board file. Yao> This patch is to convert variable checking in each reverse test case to Yao> a proc return value checking, so that gdb.reverse tests will be run on Yao> targets that support reverse debugging. Thanks for doing this. Yao> +proc support_process_record {} { Yao> + Yao> + if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } { It seems to me that both of the new procs should include the old check using target_info as well, just in case. This will avoid breaking anybody's existing setup. Ok with that change. Tom