From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85649-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29344 invoked by alias); 29 Nov 2011 19:01:34 -0000
Received: (qmail 29336 invoked by uid 22791); 29 Nov 2011 19:01:33 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 19:01:11 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pATJ18Vl022300	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 29 Nov 2011 14:01:08 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pATJ17bn008297;	Tue, 29 Nov 2011 14:01:08 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pATJ169M026671;	Tue, 29 Nov 2011 14:01:06 -0500
From: Tom Tromey <tromey@redhat.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add the "-info-os" command to MI
References: <4E970915.8000207@codesourcery.com>	<m3pqhqdqp4.fsf@fleche.redhat.com> <4ECECFEB.8020807@codesourcery.com>
Date: Tue, 29 Nov 2011 19:01:00 -0000
In-Reply-To: <4ECECFEB.8020807@codesourcery.com> (Kwok Cheung Yeung's message	of "Thu, 24 Nov 2011 23:14:51 +0000")
Message-ID: <m3k46in47h.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00826.txt.bz2

>>>>> ">" == Kwok Cheung Yeung <kcy@codesourcery.com> writes:

>> I've now created a new mi_cmd_info_os function to service -info-os,
>> which delegates to info_osdata_command in osdata.c. This is the same
>> backend that 'info os' in the CLI uses, but at least now we don't go
>> through the CLI code.
>> info_osdata_command now needs to be non-static.

Thanks for doing this.

>> gdb/
>> 	* Makefile.in (SUBDIR_MI_OBS): Add mi-cmd-info.o.
>> 	(SUBDIR_MI_SRCS): Add mi-cmd-info.c.
>> 	(mi-cmd-info.o): New rule.
>> 	* osdata.h: Add declaration for info_osdata_command.
>> 	* osdata.c (info_osdata_command): Change to non-static.
>> 	* mi/mi-cmds.c (mi_cmds): Add -info-os MI command.
>> 	* mi/mi-cmd-info.c: New.

Two nits...

>> +  { "info-os", { NULL, 0 }, mi_cmd_info_os},

mi_cmd_info_os doesn't seem to be declared anywhere.
I think this ought to cause a compilation error.

>> +      info_osdata_command (argv [0], 0);

No space before the '['.

Tom