From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20709 invoked by alias); 10 Jan 2012 19:12:36 -0000 Received: (qmail 20694 invoked by uid 22791); 10 Jan 2012 19:12:35 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 19:12:18 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0AJCGSo032732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jan 2012 14:12:16 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0AJCF56005862; Tue, 10 Jan 2012 14:12:16 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0AJCEKx022119; Tue, 10 Jan 2012 14:12:14 -0500 From: Tom Tromey To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: Building GDB 7.3.92 with MinGW References: <83hb03e9sx.fsf@gnu.org> Date: Tue, 10 Jan 2012 19:25:00 -0000 In-Reply-To: <83hb03e9sx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Jan 2012 19:39:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00303.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Any objections to the following patch? (If approved, I will add a Eli> comment explaining the problem on Windows which requires this.) Eli> --- gdb/gdb_curses.h~0 2012-01-06 06:43:14.000000000 +0200 Eli> +++ gdb/gdb_curses.h 2012-01-10 13:21:10.626119900 +0200 Eli> @@ -27,6 +27,9 @@ Eli> #elif defined (HAVE_CURSESX_H) Eli> #include Eli> #elif defined (HAVE_CURSES_H) Eli> +#if defined(__MINGW32__) && defined(MOUSE_MOVED) Eli> +#undef MOUSE_MOVED Eli> +#endif Eli> #include Eli> #endif I don't really mind this patch. But, why is this something for gdb to solve rather than mingw? Eli> 2. "make install-strip" fails in readline/, in sim/, and in gdb/: Eli> The reason is that these directories simply don't have the Eli> "install-strip" target in their Makefile.in files. I think that Eli> target should be added, because that's AFAIK how GDB is supposed to Eli> be installed on end-user systems. This is in the GNU standards, but in practice few people use it. Of course, patches are welcome. This isn't the only places where gdb's Makefiles diverge from the standards. Eli> 3. Manuals are (unexpectedly) regenerated as part of "make": Eli> I think these two files should be added to the distribution, since Eli> end users should not be required to have Texinfo installed to build Eli> GDB. No opinion on this one. Eli> Finally, a question: Why are we installing libraries (libbfd, Eli> libopcodes, libiberty) and the standards.info manual? The libraries Eli> are not part of GDB, we import them from elsewhere. "make install" Eli> will happily overwrite existing installation of these libraries that Eli> could potentially be newer, coming from their respective upstream Eli> distributions. How about removing these from "make install"? For libiberty, gcc is the authoritative source. So, ask there. For the others, ask on the binutils list. I tend to agree they should not be installed. Eli> As for standards.info, if we decide to keep distributing it (which I Eli> don't think we should), we should at least make a point of having the Eli> latest version in our tarballs; the one in 7.3.92 isn't. IMO we should remove this. Actually, most of the things in src/etc seem outdated or useless or somebody else's code. I'm not sure who owns this directory, you should ask on binutils before taking any action. Tom