From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16347 invoked by alias); 6 Dec 2013 07:36:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16336 invoked by uid 89); 6 Dec 2013 07:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f49.google.com Received: from Unknown (HELO mail-pb0-f49.google.com) (209.85.160.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 06 Dec 2013 07:36:17 +0000 Received: by mail-pb0-f49.google.com with SMTP id jt11so583699pbb.8 for ; Thu, 05 Dec 2013 23:36:09 -0800 (PST) X-Received: by 10.68.66.103 with SMTP id e7mr2497785pbt.120.1386315369564; Thu, 05 Dec 2013 23:36:09 -0800 (PST) Received: from sspiff.sspiff.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id g6sm165669959pat.2.2013.12.05.23.36.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Dec 2013 23:36:08 -0800 (PST) From: Doug Evans To: Sanimir Agovic Cc: tromey@redhat.com, palves@redhat.com, xdje42@gmail.com, gdb-patches@sourceware.org, keven.boell@intel.com Subject: Re: [PATCH v3 05/13] vla: update type from newly created value References: <1386166785-28037-1-git-send-email-sanimir.agovic@intel.com> <1386166785-28037-6-git-send-email-sanimir.agovic@intel.com> Date: Fri, 06 Dec 2013 07:36:00 -0000 In-Reply-To: <1386166785-28037-6-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Wed, 4 Dec 2013 15:19:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00237.txt.bz2 Sanimir Agovic writes: > Constructing a value based on a type and address might change the type > of the newly constructed value. Thus re-fetch type via value_type to ensure > we have the correct type at hand. > > 2013-10-18 Sanimir Agovic > Keven Boell > > * ada-lang.c (ada_value_primitive_packed_val): Re-fetch type from value. > (ada_template_to_fixed_record_type_1): Likewise. > (ada_to_fixed_type_1): Likewise. > * cp-valprint.c (cp_print_value_fields_rtti): Likewise. > (cp_print_value): Likewise. > * d-valprint.c (dynamic_array_type): Likewise. > * jv-valprint.c (java_value_print): Likewise. > * valops.c (value_ind): Likewise. > * value.c (coerce_ref): Likewise. Hi. Can you add a comment to each of the functions that require this, saying something like "You must do after calling me." value_at, value_from_contents_and_address, others? Apologies if I missed it. I think(!) I've read the entire v3 series. Thanks.