From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108889 invoked by alias); 23 Aug 2015 01:05:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108880 invoked by uid 89); 23 Aug 2015 01:05:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 01:05:11 +0000 Received: by padfo6 with SMTP id fo6so33254938pad.1 for ; Sat, 22 Aug 2015 18:05:09 -0700 (PDT) X-Received: by 10.66.157.195 with SMTP id wo3mr31751591pab.17.1440291909537; Sat, 22 Aug 2015 18:05:09 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id e8sm12432421pdm.13.2015.08.22.18.05.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Aug 2015 18:05:09 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 03/19] Implement completion-limiting for complete_on_cmdlist. References: <20150806191404.32159.50755.stgit@valrhona.uglyboxes.com> <20150806191517.32159.91797.stgit@valrhona.uglyboxes.com> Date: Sun, 23 Aug 2015 01:05:00 -0000 In-Reply-To: <20150806191517.32159.91797.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 06 Aug 2015 12:15:34 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00642.txt.bz2 Keith Seitz writes: > Differences in this revision: > > 1. Remove partial copy code from complete_on_cmdlist. > > --- > > This is the first of a series of smaller patches to switch over > all completion functions to using add_completion to add > completions to the completion list to be presented to the user. > > Note that in order to verify that this patch works as intended, > one must override the backup completion counting in complete_line. > [This backup code will be permanently removed in a later patch.] > During testing, I have verified all patches with this planned code > removal to verify that it works. > > First up is complete_on_cmdlist. Completion-limiting is already tested > in gdb.base/completion.exp, so there are no new tests. > > gdb/ChangeLog > > * cli/cli-decode.c (complete_on_cmdlist): Use add_completion > to determine whether to continue looking for completions. LGTM