From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70834 invoked by alias); 17 Apr 2018 12:28:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70816 invoked by uid 89); 17 Apr 2018 12:28:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=severe X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 12:28:41 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HCPgCo004801 for ; Tue, 17 Apr 2018 08:28:39 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hdgkks9se-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 08:28:39 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 13:28:37 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 13:28:36 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HCSZvX57081864; Tue, 17 Apr 2018 12:28:35 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19B7B11C050; Tue, 17 Apr 2018 13:20:32 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 04D2311C04A; Tue, 17 Apr 2018 13:20:32 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.201]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 17 Apr 2018 13:20:31 +0100 (BST) From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't print symbol definition's line number in rbreak output References: Date: Tue, 17 Apr 2018 12:28:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 16 Apr 2018 20:01:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18041712-0040-0000-0000-0000042FF3A6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041712-0041-0000-0000-00002633FE43 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170112 X-SW-Source: 2018-04/txt/msg00333.txt.bz2 On Mon, Apr 16 2018, Pedro Alves wrote: > On 04/16/2018 07:44 PM, Andreas Arnez wrote: >> This commit: >> >> b744723f57 -- Show line numbers in output for "info var/func/type" >> >> added the symbol definition's line number to the output of certain GDB >> commands. It also changes the `rbreak' command's output, although it >> shouldn't. This is fixed. > > Could you update this to include an example of before/after gdb > output in the commit log? Sure. How about the updated commit message below? > > Is this a regression in 8.1? No, I just caused the regression myself on Friday with the commit above. For some reason I had not noticed the impact on the `rbreak' command before. -- Andreas -- >8 -- Subject: [PATCH] Don't print symbol definition's line number in rbreak output This commit: b744723f57 -- Show line numbers in output for "info var/func/type" added the symbol declaration's line number to the output of certain GDB commands. It also changes the `rbreak' command's output, like this: (gdb) rbreak foo Breakpoint 1 at 0x40049b: file rbreak.c, line 6. 4: static int foo1(void); Breakpoint 2 at 0x4004b1: file rbreak.c, line 12. 10: static int foo2(void); (gdb) where the function declaration is now prefixed by its source line number, followed by a colon. But without showing the declaration's file name, the line number is useless and can possibly cause severe confusion. No declaration line number was shown before. Instead, the function declaration started at the first column. This old behavior is restored. In order to distinguish when to print location information, the meaning of print_symbol_info()'s parameter `last' is changed. Now NULL means to skip any filename or line number information. Previously NULL meant to always print the filename.