Re: [OB] pointer ref, m2-typeprint.c

Daniel Jacobowitz
2007-06-29T00:44:04Z

Ooh thanks, that seems to have fixed attachments.

On Thu, Jun 28, 2007 at 05:37:03PM -0700, msnyder@sonic.net wrote:
> CHECK_TYPEDEF (type);
> - code = TYPE_CODE (type);

Coverity's software is a tool, not a goal, and it's no substitute for
knowing what the code is doing. Please stop moving things around just
to make it happy. If the second line I quoted could crash, the first
line definitely will; so if TYPE can really be NULL here, we should
fix it properly (instead of this change, which removes the helpful
notice that something is wrong :-).

--
Daniel Jacobowitz
CodeSourcery