Re: [OB] pointer ref, m2-typeprint.c

Daniel Jacobowitz
2007-06-29T11:37:40Z

On Thu, Jun 28, 2007 at 06:02:41PM -0700, msnyder@sonic.net wrote:
> > If the second line I quoted could crash, the first
> > line definitely will; so if TYPE can really be NULL here, we should
> > fix it properly (instead of this change, which removes the helpful
> > notice that something is wrong :-).
>
> Nooooo... I don't think my change removes any notice.
> Take another look, please?

Sorry, I meant a notice from Coverity's tools. The problem is that it
knows TYPE_CODE is a dereference (that's a locally derivable
conclusion within this file) but as far as I can tell it doesn't know
that CHECK_TYPEDEF will always dereference its argument (it will).
So now it's not going to complain, but if there was a problem,
there still is.

--
Daniel Jacobowitz
CodeSourcery