From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8337 invoked by alias); 25 Aug 2008 19:12:14 -0000 Received: (qmail 8322 invoked by uid 22791); 25 Aug 2008 19:12:13 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Aug 2008 19:11:39 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m7PJAFvt001509; Mon, 25 Aug 2008 15:10:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7PJA4Hr004648; Mon, 25 Aug 2008 15:10:04 -0400 Received: from opsy.redhat.com (vpn-10-67.bos.redhat.com [10.16.10.67]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m7PJ9wXX030405; Mon, 25 Aug 2008 15:09:58 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 50A85378143; Mon, 25 Aug 2008 13:10:08 -0600 (MDT) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: shrink main_type References: <20080818130009.GM16894@adacore.com> <20080818132001.GA9434@caradoc.them.org> <20080819051306.GQ16894@adacore.com> <20080824101221.GA3738@adacore.com> <20080825154927.GA3768@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Mon, 25 Aug 2008 19:12:00 -0000 In-Reply-To: <20080825154927.GA3768@adacore.com> (Joel Brobecker's message of "Mon\, 25 Aug 2008 17\:49\:27 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00614.txt.bz2 Joel> I probably should have grep'ed for the various TYPE_FLAG_... names that Joel> you changed when I reviewed your patch instead of assuming that you got Joel> them all - I got lazy because I am under a bit of time pressure :-(. Bah -- no, I don't agree, since of course you should be able to trust me to do it. And actually I did do it, except I forgot to fully re-check pre-commit, and I was relying on idutils, which didn't find the TYPE_FLAG instance in a string. Bah. Joel> Like you said, we'll fix any problem you might have left, so no big deal Joel> as far as I am concerned. Thanks for acting on it so diligently :) If I'm going to make mistakes the least I can do is clean them up :) Tom