From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21792 invoked by alias); 21 Oct 2008 18:56:42 -0000 Received: (qmail 21783 invoked by uid 22791); 21 Oct 2008 18:56:42 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Oct 2008 18:56:07 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9LIrwU4001053; Tue, 21 Oct 2008 14:53:58 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9LIrvDi030897; Tue, 21 Oct 2008 14:53:58 -0400 Received: from opsy.redhat.com (vpn-13-238.rdu.redhat.com [10.11.13.238]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m9LIrvBj005112; Tue, 21 Oct 2008 14:53:57 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 50918508073; Tue, 21 Oct 2008 12:53:56 -0600 (MDT) To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix PR 2506 References: <200810211727.18574.pedro@codesourcery.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Tue, 21 Oct 2008 18:56:00 -0000 In-Reply-To: <200810211727.18574.pedro@codesourcery.com> (Pedro Alves's message of "Tue\, 21 Oct 2008 17\:27\:17 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00516.txt.bz2 Pedro> This crashes for me: Pedro> print "foo" "bar" "boo" Pedro> :-( Thanks. I added a new test case and fixed this problem. I'm sending it back through the regression tester now. Pedro> Also, these files don't use xmalloc/xfree. Instead, one writes Pedro> malloc/free; they're sed'ed by the build system --- see the top of Pedro> c-exp.y. I made this change. Two notes here: first, the Makefile doesn't actually s/free/xfree/ -- it only handles malloc and realloc. Funny. This should not really matter in practice. Second, ada-exp.y uses xmalloc once and p-exp.y uses xfree once, in case anybody wants to clean that up. I'll resubmit once the testing is finished. Tom