From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32712 invoked by alias); 28 May 2009 01:16:38 -0000 Received: (qmail 32702 invoked by uid 22791); 28 May 2009 01:16:37 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 May 2009 01:16:29 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1M9UEM-0007lJ-2B for gdb-patches@sources.redhat.com; Thu, 28 May 2009 01:16:26 +0000 Received: from 207.189.193.221 ([207.189.193.221]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 28 May 2009 01:16:26 +0000 Received: from tromey by 207.189.193.221 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 28 May 2009 01:16:26 +0000 To: gdb-patches@sources.redhat.com From: Tom Tromey Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections. Date: Thu, 28 May 2009 01:16:00 -0000 Message-ID: References: <20090527001157.934BD76BC0@localhost> Reply-To: tromey@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00599.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: I like this patch quite a bit. It has a number of minor formatting problems, mostly missing spaces before open parens. Paul> + caddr_t retbuf = mmap (0, map_length, PROT_READ, MAP_PRIVATE, Paul> + fileno ((FILE *)abfd->iostream), Paul> + pg_offset); I don't know for sure, but I assume that it is not valid in general to cast iostream like this. Tom