From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24757 invoked by alias); 1 Sep 2009 21:27:06 -0000 Received: (qmail 24749 invoked by uid 22791); 1 Sep 2009 21:27:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Sep 2009 21:26:59 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n81LQupQ022082 for ; Tue, 1 Sep 2009 17:26:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n81LQueP023341; Tue, 1 Sep 2009 17:26:56 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n81LQthD008375; Tue, 1 Sep 2009 17:26:55 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 0169D378211; Tue, 1 Sep 2009 15:26:54 -0600 (MDT) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] dwarf2_physname References: <4A9C358E.2050904@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 01 Sep 2009 21:27:00 -0000 In-Reply-To: <4A9C358E.2050904@redhat.com> (Keith Seitz's message of "Mon, 31 Aug 2009 13:41:50 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00032.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> In an effort to help maintainers assess the code in smaller chunks Keith> without introducing new, temporary test suite failures, I'm going to Keith> try something "different" -- this patch, and the follow-ons, will not Keith> actually do anything until a final patch turns it all on. My hope is Keith> that this will be minimally intrusive to GDB's code base, especially Keith> given all the talk of a new release. This seems fine to me, though as a procedural issue I would suggest that you not commit anything until the whole series is approved. (The alternative seems to be committing unused code, which I think we should not do in general.) If this is a hardship for some reason we can discuss it. I haven't read your patch in depth yet but I wanted to mention a couple of things. I'll look at the rest soon. Keith> Based on work from Daniel Jacobowitz : Keith> * typeprint.h (c_type_print_args): Declare. Keith> * ui-file.h (ui_file_obsavestring): Declare. Keith> * c-typeprint.c (c_type_print_args): Add to global namespace. Keith> Add "show_articifical" parameter and only print them when Keith> requested. Keith> * ui-file.c (do_ui_file_obsavestring): New function. Keith> (ui_file_obsavestring): New function. All of this part looked ok. Keith> +/* A vector used during linkage name generation. */ Keith> +typedef struct die_info *die_info_p; Keith> +DEF_VEC_P (die_info_p); Keith> +static VEC(die_info_p) *die_list; I wonder if a global is really necessary. I didn't check. Keith> + VEC_quick_push (die_info_p, die_list, d); AFAICT the vector is only added to with VEC_quick_push. This will die, though, if there is insufficient space in the vec. So, something must be missing here -- either an explicit initialization of the vec, or this should use VEC_safe_push. Tom