From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20127 invoked by alias); 10 Dec 2009 16:59:48 -0000 Received: (qmail 20113 invoked by uid 22791); 10 Dec 2009 16:59:48 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Dec 2009 16:59:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBAGxfQk002205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Dec 2009 11:59:41 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBAGxecg022688; Thu, 10 Dec 2009 11:59:41 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBAGxd6s015744; Thu, 10 Dec 2009 11:59:40 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6E98E3782A3; Thu, 10 Dec 2009 09:59:39 -0700 (MST) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: Patch for PR 9399 References: <4B1FA6F2.1060105@redhat.com> Reply-To: tromey@redhat.com Date: Thu, 10 Dec 2009 16:59:00 -0000 In-Reply-To: <4B1FA6F2.1060105@redhat.com> (Chris Moller's message of "Wed, 09 Dec 2009 08:32:34 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00142.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> The attached stuff is a patch for PR9399: Chris> I've assigned that bug to myself. If you're happy with the patch, let Chris> me know and I'll close the bug. (Or do whatever you usually do...) Yeah, what I do is set the target milestone to 7.1 and close as FIXED after the patch is committed. Chris> + /* Check to see if any kind of cast is necessary; if not, punt. Chris> + (Specifically not using strcmp_iw() because no other comparisons against Chris> + TYPE_NAME() use it. They all use standard strcmp() instead.) */ Delete this comment. Chris> /* This test script is part of GDB, the GNU debugger. Chris> Copyright 1993, 1994, 1997, 1998, 1999, 2003, 2004, 2009 Just 2009. Chris> # Copyright 1992, 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, Chris> # 2006, 2007, 2008, 2009 Free Software Foundation, Inc. Likewise. This is ok with those changes. Thanks. Tom